Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: remove usage of require('util') #26818

Closed
wants to merge 1 commit into from
Closed

readline: remove usage of require('util') #26818

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 20, 2019

Use require('internal/util/inspect').inspect instead of
require('util').inspect.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dnlup
readline: remove usage of require('util')
fef8c22 
Use `require('internal/util/inspect').inspect` instead of 
`require('util').inspect`.

Refs: nodejs#26546
@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Mar 20, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
@ZYSzys
Copy link
Member

ZYSzys commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21731/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21761/

@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR
Copy link
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21800/

@ZYSzys
Copy link
Member

ZYSzys commented Mar 23, 2019

Landed in 2701f55 🎉

@ZYSzys ZYSzys closed this Mar 23, 2019
ZYSzys pushed a commit that referenced this pull request Mar 23, 2019
@dnlup @ZYSzys
readline: remove usage of require('util')
2701f55 
Use `require('internal/util/inspect').inspect` instead of
`require('util').inspect`.

Refs: #26546

PR-URL: #26818
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dnlup dnlup deleted the util_readline branch January 10, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dnlup @ZYSzys @BridgeAR @jasnell @targos @nodejs-github-bot