Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: reduce internal usage of public util for manifest.js #26833

Closed
wants to merge 1 commit into from
Closed

lib: reduce internal usage of public util for manifest.js #26833

wants to merge 1 commit into from

Conversation

Naturalclar
Copy link
Contributor

This PR is part of issue #26546

Replaced usage of public require('util')

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Naturalclar Naturalclar mentioned this pull request Mar 21, 2019
Closed
@ZYSzys
Copy link
Member

ZYSzys commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21718/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 23, 2019

Landed in afdadbc 🎉

@ZYSzys ZYSzys closed this Mar 23, 2019
ZYSzys pushed a commit that referenced this pull request Mar 23, 2019
@Naturalclar @ZYSzys
policy: reduce internal usage of public util for manifest.js
afdadbc 
PR-URL: #26833
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@Naturalclar @targos
policy: reduce internal usage of public util for manifest.js
7f116c3 
PR-URL: nodejs#26833
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@Naturalclar @targos
policy: reduce internal usage of public util for manifest.js
c127bec 
PR-URL: #26833
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@shisama shisama shisama approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Naturalclar @ZYSzys @jasnell @lpinca @targos @BridgeAR @shisama