-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: use consolePropAttributes for k-bind properties in constructor #26850
Closed
BeniCheni
wants to merge
1
commit into
nodejs:master
from
BeniCheni:console-constructor-k-bind-props
Closed
console: use consolePropAttributes for k-bind properties in constructor #26850
BeniCheni
wants to merge
1
commit into
nodejs:master
from
BeniCheni:console-constructor-k-bind-props
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
console
Issues and PRs related to the console subsystem.
label
Mar 22, 2019
mihalskiy
approved these changes
Mar 22, 2019
joyeecheung
approved these changes
Mar 23, 2019
ZYSzys
approved these changes
Mar 23, 2019
BridgeAR
approved these changes
Mar 25, 2019
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 25, 2019
Landed in ed5e69d. |
danbev
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26850 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
It seems that this gone failed our travis CI (if I'm not wrong), do we need to revert this one ?
|
I'll take a closer look now and a PR to revert this. Thanks for point this out! |
2 tasks
danbev
added a commit
that referenced
this pull request
Mar 27, 2019
…onstructor" This reverts commit ed5e69d. PR-URL: #26943 Refs: #26850 (comment) Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Apr 23, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 29, 2019
This is a reland of nodejs#26850. It was speculatively reverted but it turned out that this did not cause any trouble. PR-URL: nodejs#27352 Refs: nodejs#26943 Refs: nodejs#26850 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
This is a reland of #26850. It was speculatively reverted but it turned out that this did not cause any trouble. PR-URL: #27352 Refs: #26943 Refs: #26850 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
console
Issues and PRs related to the console subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After checking out the TODO comment in
lib/internal/console/constructor.js
, this PR follows the suggestion to useconsolePropAttributes
when defining these k-bind properties in thethis
object.node/lib/internal/console/constructor.js
Lines 184 to 189 in db40b4a
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes