Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pummel tls test #26865

Closed
wants to merge 2 commits into from
Closed

Fix pummel tls test #26865

wants to merge 2 commits into from

Commits on Mar 22, 2019

  1. test: fix pummel/test-tls-session-timeout 

    The test does not work with TLS 1.3 nor should it. Force TLS version
1.2.

While at it, some refactoring:

* refresh the tmp directory in case it doesn't exist!
* add an assert.strictEqual() check on the client return `code` value
  which must be zero
* use arrow functions for callbacks
* add trailing commas for multiline arrays/objects

Fixes: nodejs#26839
    @Trott
    Trott committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    3ea61d3 View commit details
    Browse the repository at this point in the history

  2. test: move pummel tls test to sequential 

    Move test-tls-session-timeout from pummel to sequential. It isn't very
pummel-y and this will result in it being run on our CI more than once a
day. (It broke recently and it would have been caught if it was in
sequential rather than pummel.)

It must be in sequential rather than pummel because it uses
`common.PORT` which can result in test failures if more than one test
uses it at one time in parallel.
    @Trott
    Trott committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    6f79f6e View commit details
    Browse the repository at this point in the history