Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix make pkg osx #2687

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ $(PKG): release-only
| sed -E "s/\\{npmversion\\}/$(NPMVERSION)/g" \
> tools/osx-pkg.pmdoc/index.xml
$(PACKAGEMAKER) \
--id "org.node.pkg" \
--id "org.nodejs.pkg" \
--doc tools/osx-pkg.pmdoc \
--out $(PKG)
SIGN="$(PRODUCTSIGN_CERT)" PKG="$(PKG)" bash tools/osx-productsign.sh
Expand Down
2 changes: 1 addition & 1 deletion tools/osx-pkg.pmdoc/01local.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<pkgref spec="1.12" uuid="053587FE-BDF3-4EF5-815D-281427431048">
<config>
<identifier>org.iojs.iojs.pkg</identifier>
<identifier>org.nodejs.node.pkg</identifier>
<version>1.0</version>
<description></description>
<post-install type="none"/>
Expand Down
2 changes: 1 addition & 1 deletion tools/osx-pkg.pmdoc/02npm.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<pkgref spec="1.12" uuid="DF0233A3-6B5D-4FBF-8048-8FC57F42278F">
<config>
<identifier>org.node.npm.pkg</identifier>
<identifier>org.nodejs.npm.pkg</identifier>
<version>1.0</version>
<description></description>
<post-install type="none"/>
Expand Down
4 changes: 2 additions & 2 deletions tools/osx-pkg.pmdoc/index.xml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
</distribution>
<contents>
<choice title="Node.js" id="choice1" starts_selected="true" starts_enabled="true" starts_hidden="false">
<pkgref id="org.nodejs.pkg"/>
<pkgref id="org.nodejs.node.pkg"/>
</choice>
<choice title="npm" id="choice2" starts_selected="true" starts_enabled="true" starts_hidden="false">
<pkgref id="org.nodejs.node.npm.pkg"/>
<pkgref id="org.nodejs.npm.pkg"/>
</choice>
</contents>
<resources bg-scale="none" bg-align="topleft">
Expand Down