Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and improve flaky test-https-connect-localport #26881

Closed
wants to merge 4 commits into from
Closed

fix and improve flaky test-https-connect-localport #26881

wants to merge 4 commits into from

Commits on Mar 23, 2019

  1. test: move test-https-connect-localport to sequential 

    test-https-connect-localport uses a hard-coded port number. Therefore
the test cannot be in the parallel directory because it will sometimes
conflict with other tests that run at the same time and request that the
OS provide an available port.

Fixes: nodejs#26862
    @Trott
    Trott committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    dad3deb View commit details
    Browse the repository at this point in the history

  2. test: use common.PORT instead of hardcoded number 

    In sequential/test-https-connect-localport, replace 34567 with
common.PORT.
    @Trott
    Trott committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    0afa99b View commit details
    Browse the repository at this point in the history

  3. test: replace localhost IP with 'localhost' for TLS conformity 

    test-https-connect-localport currently causes a runtime deprecation
warning: "[DEP0123] DeprecationWarning: Setting the TLS ServerName
to an IP address is not permitted by RFC 6066. This will be ignored
in a future version."

Change IP usage to the string 'localhost' instead.
    @Trott
    Trott committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    5348b10 View commit details
    Browse the repository at this point in the history

  4. test: refactor test-https-connect-localport 

    Use arrow functions for callbacks. Replace uses of `this` with explicit
variables. Add a trailing comma in a multiline object literal
declaration.
    @Trott
    Trott committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    277ede3 View commit details
    Browse the repository at this point in the history