Revert "net: remove usage of require('util')" #26896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e112fb4. This commit broke parallel/test-net-access-byteswritten.
bnoordhuis
approved these changes
Mar 25, 2019
ZYSzys
approved these changes
Mar 25, 2019
devsnek
approved these changes
Mar 25, 2019
Trott
added
the
author ready
|
(FreeBSD failed with flaky parallel/test-gc-http-client-onerror, re-running: https://ci.nodejs.org/job/node-test-commit-freebsd/25082/) |
cjihrig
approved these changes
Mar 25, 2019
refack
approved these changes
Mar 25, 2019
|
FreeBSD re-run passed, landing. |
|
Landed in 3f41fcb |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 25, 2019
This reverts commit e112fb4. This commit broke parallel/test-net-access-byteswritten. PR-URL: nodejs#26896 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
@Trott thanks a lot for fixing this! I force pushed to my fork instead of upstream after noticing the problem. |
2 tasks
dnlup
added a commit
to dnlup/node
that referenced
this pull request
Mar 26, 2019
Use `require('internal/util/inspect').inspect`,
`require('internal/util/debuglog').debuglog`,
`require('internal/util').deprecate` and `Object.setPrototypeOf` instead
of `require('util')`.
Fix test in `test/parallel/test-net-access-byteswritten.js` to do not
check the `super_` property that was set when using
`require('util').inherits`.
Refs: nodejs#26546
Refs: nodejs#26896
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
This reverts commit e112fb4. This commit broke parallel/test-net-access-byteswritten. PR-URL: nodejs#26896 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
This reverts commit e112fb4. This commit broke parallel/test-net-access-byteswritten. PR-URL: #26896 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
Use `require('internal/util/inspect').inspect`,
`require('internal/util/debuglog').debuglog`,
`require('internal/util').deprecate` and `Object.setPrototypeOf` instead
of `require('util')`.
Fix test in `test/parallel/test-net-access-byteswritten.js` to do not
check the `super_` property that was set when using
`require('util').inherits`.
Refs: #26546
Refs: #26896
PR-URL: #26920
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Use `require('internal/util/inspect').inspect`,
`require('internal/util/debuglog').debuglog`,
`require('internal/util').deprecate` and `Object.setPrototypeOf` instead
of `require('util')`.
Fix test in `test/parallel/test-net-access-byteswritten.js` to do not
check the `super_` property that was set when using
`require('util').inherits`.
Refs: #26546
Refs: #26896
PR-URL: #26920
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e112fb4.
This commit broke parallel/test-net-access-byteswritten.
Refs: #26807 (comment)
Did a bisect and arrived at the same conclusion.
Collaborators, please 👍 here to fast-track.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes