Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove test-path-parse-6229.js from known issues #26913

Closed
wants to merge 1 commit into from
Closed

test: remove test-path-parse-6229.js from known issues #26913

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This test precedented the official documentation that states that
this is an expected behavior.

Refs: #6229
Refs: #12181

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
test: remove test-path-parse-6229.js from known issues
663543a 
This test precedented the official documentation that states that
this is an expected behavior.

Refs: nodejs#6229
Refs: nodejs#12181
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3042/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 26, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/21953/

@BridgeAR
Copy link
Member Author

@nodejs/testing PTAL

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 29, 2019
@BridgeAR
test: remove test-path-parse-6229.js from known issues
f9da55c 
This test precedented the official documentation that states that
this is an expected behavior.

PR-URL: nodejs#26913
Refs: nodejs#6229
Refs: nodejs#12181
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR
Copy link
Member Author

Landed in f9da55c.

@BridgeAR BridgeAR closed this Mar 29, 2019
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@BridgeAR @BethGriggs
test: remove test-path-parse-6229.js from known issues
ec6b361 
This test precedented the official documentation that states that
this is an expected behavior.

PR-URL: #26913
Refs: #6229
Refs: #12181
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
@BridgeAR @BethGriggs
test: remove test-path-parse-6229.js from known issues
fd6381b 
This test precedented the official documentation that states that
this is an expected behavior.

PR-URL: #26913
Refs: #6229
Refs: #12181
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
@BridgeAR BridgeAR deleted the remove-faulty-known-issue branch January 20, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@tniessen tniessen Awaiting requested review from tniessen

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BridgeAR @nodejs-github-bot @Trott @targos