Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,meta: tweak Travis config #26969

Merged
merged 1 commit into from
Apr 2, 2019
Merged

build,meta: tweak Travis config #26969

merged 1 commit into from
Apr 2, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Mar 28, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack Sadly, an error occurred when I tried to trigger a build. :(

@refack refack marked this pull request as ready for review March 28, 2019 21:29
richardlau
richardlau reviewed Mar 28, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@richardlau
Copy link
Member

Reminder that if you're bumping the gcc version you may have to land in more than one commit to populate the ccache as I had to when we moved to gcc 6 (#26720 (comment)).

@refack
Copy link
Contributor Author

refack commented Mar 28, 2019

Reminder that if you're bumping the gcc version you may have to land in more than one commit

Mostly wanted to see if this builds faster. Since we might get in the same mess when we land V8 or change INCLUDES in common.gypi...

BTW: https://docs.travis-ci.com/user/caching/#pull-request-builds-and-caches cache lookup and storage is fairly nuanced.

@richardlau
Copy link
Member

Reminder that if you're bumping the gcc version you may have to land in more than one commit

Mostly wanted to see if this builds faster. Since we might get in the same mess when we land V8 or change INCLUDES in common.gypi...

Travis builds are now timing out, which I suspect might be the recent V8 update 😢.

refack
refack commented Mar 29, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
@refack
Copy link
Contributor Author

refack commented Mar 30, 2019

Ok first Travis job passed, so I cleared the cache and restarted.

@refack refack self-assigned this Mar 30, 2019
@refack refack added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Mar 30, 2019
@refack
Copy link
Contributor Author

refack commented Mar 30, 2019

This is ready for review.

/CC @nodejs/build-files @nodejs/testing

richardlau
richardlau reviewed Mar 30, 2019
View reviewed changes
.travis.yml Outdated
script:
- PARALLEL_ARGS='--flaky-tests=skip' make -j1 test
- TEST_CI_ARGS="--flaky-tests=skip --report default" make -j1 V= test-ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the tap format used by test-ci Travis truncates the log in the web UI. e.g. https://travis-ci.com/nodejs/node/jobs/188985249 so you need to click through to the raw logs to see the full test results.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some grepping to get it down to ~6K lines

.travis.yml Show resolved Hide resolved
richardlau
richardlau reviewed Mar 30, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
richardlau
richardlau approved these changes Mar 30, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2019
@refack
Copy link
Contributor Author

refack commented Apr 1, 2019

Ping @nodejs/build-files @nodejs/testing

@refack
build,meta: tweak Travis config
7bf5171 
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`

PR-URL: nodejs#26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@refack refack merged commit 7bf5171 into nodejs:master Apr 2, 2019
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@refack @BethGriggs
build,meta: tweak Travis config
c021719 
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`

PR-URL: #26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@refack refack deleted the travis-tweaks branch April 7, 2019 15:01
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@refack @BethGriggs
build,meta: tweak Travis config
a96ad39 
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`

PR-URL: #26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@refack @BethGriggs
build,meta: tweak Travis config
d8aaf2e 
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`

PR-URL: #26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@refack @BethGriggs
build,meta: tweak Travis config
b766c06 
* Add `lint-py-build` to get `lint-ci` to lint python
* Add compile V8 job
* Make compilation verbose
* Test with `test-ci`

PR-URL: #26969
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@refack refack removed their assignment Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refack @nodejs-github-bot @richardlau @joyeecheung @BridgeAR