Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: list when promiseResolve hook was added to async_hooks #26978

Closed
wants to merge 1 commit into from
Closed

doc: list when promiseResolve hook was added to async_hooks #26978

wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Mar 29, 2019 •
edited by BridgeAR
Loading

Refs: #15296

Checklist

@nodejs-github-bot
Copy link
Collaborator

@watson Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Mar 29, 2019
@BridgeAR
Copy link
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3092/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2019
@watson
Copy link
Member Author

watson commented Mar 29, 2019

The Travis test took too long to run and was killed. Is there a way I can restart it?

@watson watson self-assigned this Apr 1, 2019
@watson
Copy link
Member Author

watson commented Apr 1, 2019

Landed in fcdee74

@watson watson closed this Apr 1, 2019
@watson watson deleted the ah branch April 1, 2019 14:23
watson added a commit that referenced this pull request Apr 1, 2019
@watson
doc: list when promiseResolve hook was added to async_hooks
fcdee74 
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@watson @BethGriggs
doc: list when promiseResolve hook was added to async_hooks
66f0529 
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@watson @BethGriggs
doc: list when promiseResolve hook was added to async_hooks
e81a391 
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@watson @BethGriggs
doc: list when promiseResolve hook was added to async_hooks
b88871e 
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@watson @BethGriggs
doc: list when promiseResolve hook was added to async_hooks
57207e7 
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@watson watson

Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@watson @nodejs-github-bot @BridgeAR @Qard @cjihrig