Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: warn on non-portable mkdtemp() templates #26980

Merged
merged 1 commit into from
Apr 9, 2019
Merged

fs: warn on non-portable mkdtemp() templates #26980

merged 1 commit into from
Apr 9, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 29, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Mar 29, 2019
@cjihrig cjihrig mentioned this pull request Mar 29, 2019
Merged
3 tasks
BridgeAR
BridgeAR reviewed Mar 29, 2019
View reviewed changes
lib/internal/fs/utils.js Outdated Show resolved Hide resolved
@vtjnash vtjnash mentioned this pull request Mar 30, 2019
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 7, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22269/

EDIT(cjihrig): CI was yellow.

@cjihrig
fs: warn on non-portable mkdtemp() templates
b925379 
Refs: nodejs#26435
PR-URL: nodejs#26980
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit b925379 into nodejs:master Apr 9, 2019
@cjihrig cjihrig deleted the warn branch April 9, 2019 01:19
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @nodejs-github-bot @jasnell @BridgeAR