build: don't use lint-ci on Travis #27062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
If it was just the case of the linter failure not being visible we could echo the tap file in the |
refack
approved these changes
Apr 2, 2019
BridgeAR
approved these changes
Apr 3, 2019
BridgeAR
added
the
author ready
mihalskiy
approved these changes
Apr 3, 2019
The `lint-ci` Makefile target differs from `lint` in that it writes to a tap file and not stdout and also stops execution when an error is found (e.g. if JavaScript linting fails the C++ and docs linting are not run). The switch to `lint-ci` was to enable Python linting. Revert to `lint` and add the `lint-py` target. PR-URL: nodejs#27062 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in af03de4. |
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lint-ciMakefile target differs fromlintin that it writes toa tap file and not stdout and also stops execution when an error is
found (e.g. if JavaScript linting fails the C++ and docs linting are
not run).
The switch to
lint-ciwas to enable Python linting. Revert tolintand add the
lint-pytarget.Example Travis run where
lintis used (note that C++ and docs linting occur after the JavaScript linter fails):https://travis-ci.com/nodejs/node/jobs/189665652
Example Travis run where
lint-ciis used (note that C++ and docs linting are not attempted after JavaScript linter fails and the actual linter failure is not visible):https://travis-ci.com/nodejs/node/jobs/189720838
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes