Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: enforce the use of Object from primordials #27146

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 9, 2019

No description provided.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 9, 2019
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@danbev
Copy link
Contributor

danbev commented Apr 12, 2019

Landed in 908292c.

@trptcolin
Copy link

I just wanted to say thank you for this fix! 🙇 ❤️ Much appreciated.

Bumped up against this issue on an older node version due to a userspace monkey-patch (of Object.defineProperty in an ES5 shim from one of our dependencies, and I'm glad to see someone's already done the hard work of solving the underlying issue. Thanks!

@targos targos deleted the primordial-object branch May 18, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.