build,win: put all compilation artifacts into out

[refack]

Solves (almost completely) the unnecessary distribution of build artifacts all over the repo.
In order to keep this semver-patch I've added a symlinking step:
https://github.com/nodejs/node/blob/2ee659cde1975a247dfa3d30d765eb9fdd3973f4/vcbuild.bat#L326-L327

Also has some small tweaks.

_{what's left to solve is the locations of the .vcxproj files. That requires a GYP patch}

/CC @nodejs/build-files @nodejs/platform-windows

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3209

[bnoordhuis]

Not a Windows expert but the changes LGTM.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22374/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22376/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22392/

[richardlau]

@refack:

I've just spent a long time trying to work out why changes I made weren't being reflected when I run node... It turns out on Windows 7 I'm getting this:

  node.vcxproj -> out\Release\\node.exe
You do not have sufficient privilege to perform this operation.

C:\work\node\github\nodejs>

i.e.

node/vcbuild.bat

Line 327 in 9b6b567

if EXIST out\%config% mklink /D %config% out\%config%

is failing.

Unfortunately I didn't immediately spot this and ended up running the old Release\node from a previous compilation before this PR landed (tools/test.py still looks for Release\node). It works if I run the command prompt as administrator but I previously did not have to do that to build Node.js.

Does this work on later versions of Windows without Administrator privileges? (I can't check on Windows 10 until Monday at the earliest).

[refack]

Thanks for the report.

  node.vcxproj -> out\Release\\node.exe
You do not have sufficient privilege to perform this operation.

C:\work\node\github\nodejs>

Did vcbuild.bat exit at that point?

Does this work on later versions of Windows without Administrator privileges? (I can't check on Windows 10 until Monday at the earliest).

It was an issue that was addressed by MS for Windows 10 (at least, maybe even for Windows 8.1).
I run my dev env in a non privileged cmd session, so this should be Ok. I'll triple check.

On CI we do run under an admin account by in an non privileged session, so that's half way to a proper testing env (we do not CI test with Windows 7, but we do with Server2008R2 which is the equivalent Server release).

(tools/test.py still looks for Release\node).

Originally I fixed that, but choose to revert because of CI legacy issues...

P.S. posted a notice at https://github.com/orgs/nodejs/teams/collaborators/discussions/72

[richardlau]

Thanks for the report.

  node.vcxproj -> out\Release\\node.exe
You do not have sufficient privilege to perform this operation.

C:\work\node\github\nodejs>

Did vcbuild.bat exit at that point?

No it continues, which is why I missed it the first few times and only really spotted it when I cut down my vcbuild.bat invocation to vcbuild.bat openssl-no-asm.

Does this work on later versions of Windows without Administrator privileges? (I can't check on Windows 10 until Monday at the earliest).

It was an issue that was addressed by MS for Windows 10 (at least, maybe even for Windows 8.1).
I run my dev env in a non privileged cmd session, so this should be Ok. I'll triple check.

On CI we do run under an admin account by in an non privileged session, so that's half way to a proper testing env (we do not CI test with Windows 7, but we do with Server2008R2 which is the equivalent Server release).

(tools/test.py still looks for Release\node).

Originally I fixed that, but choose to revert because of CI legacy issues...

ack

[joyeecheung]

I think the logic added here is off. I got this from a fresh clone:

C:\Users\joyee\projects\node>rd Release
The system cannot find the file specified.

C:\Users\joyee\projects\node>if errorlevel 1 echo "Old build output exists at 'out\Release'. Please remove."   & exit /B

C:\Users\joyee\projects\node>if EXIST out\Release mklink /D Release out\Release
You do not have sufficient privilege to perform this operation.

C:\Users\joyee\projects\node>if errorlevel 1 exit /B

I currently just comments out this logic as a workaround (cctest does not work if I do that, it would be better if we just replace %config% with out/%config% in the script), but there might be other people running into this.

[joyeecheung]

I fixed the permission issue by turning on Developer mode which allows mklink without administrator privileges (there is probably some group policy for this but I got lazy). A note about this should probably be PR'd into BUILDING.md...

[richardlau]

I think the logic added here is off. I got this from a fresh clone:

C:\Users\joyee\projects\node>rd Release
The system cannot find the file specified.

C:\Users\joyee\projects\node>if errorlevel 1 echo "Old build output exists at 'out\Release'. Please remove."   & exit /B

C:\Users\joyee\projects\node>if EXIST out\Release mklink /D Release out\Release
You do not have sufficient privilege to perform this operation.

C:\Users\joyee\projects\node>if errorlevel 1 exit /B

I currently just comments out this logic as a workaround (cctest does not work if I do that, it would be better if we just replace %config% with out/%config% in the script), but there might be other people running into this.

I'm currently setting up a new Windows 10 install and am also running into this. I'll try turning on developer mode.

[refack]

I'm currently setting up a new Windows 10 install and am also running into this. I'll try turning on developer mode.

Could you check if mklink /J Release out\Release works without elevation or dev-mode?

[richardlau]

I'm currently setting up a new Windows 10 install and am also running into this. I'll try turning on developer mode.

Could you check if mklink /J Release out\Release works without elevation or dev-mode?

C:\work\nodejs\github\node>mklink /D Release out\Release
You do not have sufficient privilege to perform this operation.

C:\work\nodejs\github\node>mklink /J Release out\Release
Junction created for Release <<===>> out\Release

C:\work\nodejs\github\node>

[refack]

C:\work\nodejs\github\node>mklink /J Release out\Release
Junction created for Release <<===>> out\Release

Thanks!
Opened #27736