-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: specify return type for tty.isatty() #27154
doc: specify return type for tty.isatty() #27154
Conversation
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Landed in 643a2fa |
PR-URL: #27154 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@silverwind those issues seem to be related to |
@BridgeAR ah, you're actually correct. I assumed they use the same implementation underneath, but this seems not the case. parent.js require("child_process").exec("node child.js", (_, stdout) => process.stdout.write(stdout)); child.js console.log(process.stdin.isTTY);
console.log(process.stdin.isRaw);
console.log(process.stdin.setRawMode);
console.log(process.stdout.columns);
console.log(require("tty").isatty(process.stdin));
console.log(require("tty").isatty(process.stdout));
undefined
undefined
undefined
undefined
false
false |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes