src: make a Environment-independent proxy class for NativeModuleLoader #27160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch splits
NativeModuleLoader
into two parts - a singletonthat only relies on v8 and
node::Mutex
and a proxy class forthe singleton (
NativeModuleEnv
) that provides limited access tothe singleton as well as C++ bindings for the Node.js binary.
NativeModuleLoader
is then no longer aware ofEnvironment
.This is split out of #27135
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes