Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,tools: use mkcodecache to add code cache to the binaries #27161

Merged
merged 3 commits into from
Apr 16, 2019
Merged

build,tools: use mkcodecache to add code cache to the binaries #27161

merged 3 commits into from
Apr 16, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 9, 2019

Based on #27135
and #27108

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 9, 2019
@refack refack mentioned this pull request Apr 9, 2019
Closed
2 tasks
@refack refack requested a review from joyeecheung April 9, 2019 22:09
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@refack refack force-pushed the new-mkcodecache branch from 9a599ef to 62e7eb9 Compare April 9, 2019 22:14
@nodejs nodejs deleted a comment from nodejs-github-bot Apr 9, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@refack refack added the review wanted PRs that need reviews. label Apr 10, 2019
@refack
Copy link
Contributor Author

refack commented Apr 10, 2019

Current change-set works on all platforms (except the RPIs), test failures are most probably flakes.

Reviews are welcome.

@refack refack added build Issues and PRs related to build files or the CI. process Issues and PRs related to the process subsystem. labels Apr 10, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
joyeecheung
joyeecheung approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Makefile Show resolved Hide resolved
configure.py Show resolved Hide resolved
@refack refack force-pushed the new-mkcodecache branch 2 times, most recently from 501a151 to 1d2feb7 Compare April 13, 2019 14:49
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@joyeecheung joyeecheung mentioned this pull request Apr 17, 2019
Closed
2 tasks
@refack refack deleted the new-mkcodecache branch April 22, 2019 14:36
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@refack refack mentioned this pull request Apr 27, 2019
Closed
This was referenced Jan 15, 2020
Open
Merged
Merged
Open
Merged
Merged
Open
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. lib / src Issues and PRs related to general changes in the lib or src directory. notable-change PRs with changes that should be highlighted in changelogs. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@refack @nodejs-github-bot @joyeecheung @BridgeAR