-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: revise TSC text in GOVERNANCE.md #27169
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tighten up a few things to make them more concise. Clarify that changes to the charter require board approval.
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Apr 10, 2019
cjihrig
approved these changes
Apr 10, 2019
BethGriggs
approved these changes
Apr 10, 2019
jasnell
approved these changes
Apr 10, 2019
vsemozhetbyt
added
doc
Issues and PRs related to the documentations.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Apr 10, 2019
mhdawson
approved these changes
Apr 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in 7b85495 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 12, 2019
Tighten up a few things to make them more concise. Clarify that changes to the charter require board approval. PR-URL: nodejs#27169 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tighten up a few things to make them more concise. Clarify that changes
to the charter require board approval.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes