Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: optimize total Travis run time #27182

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 10, 2019

  • skip compilation by using cache
  • split testing into two jobs
  • DRY with YAML anchors

Refs: #27158

Eliminates the stages; they are unnecessary for a typical CI run, and extend the run time by at least 3.5 minutes.
Instead of eliminating the compile stage it now caches the binary so the test stage doesn't need to bootstrap the compiler and doesn't need to recompile.

/CC @nodejs/testing @nodejs/build-files @nodejs/python

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 10, 2019
@refack refack self-assigned this Apr 10, 2019
@refack refack force-pushed the optimize-travis-time branch 3 times, most recently from 1d940ba to f3b8644 Compare April 10, 2019 22:30
@refack
Copy link
Contributor Author

refack commented Apr 10, 2019

This configuration can potentially finish in 6 + 5 minutes 🚀

P.S. Success image

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ab)using the ccache to transfer binaries between compile and test jobs ✔️💡.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@richardlau
Copy link
Member

richardlau commented Apr 10, 2019

Try to cut down the total time for a Travis CI sanity test.

Eliminates the stages; they are unnecessary for a typical CI run, and extend the run time by at least 3.5 minutes.
For PRs that change V8, the first successful run of "Compile V8" will hydrate the cache, so subsequent runs should complete in < 50 minutes

Maybe update the OP? Stages haven't been eliminated.

@refack refack force-pushed the optimize-travis-time branch 3 times, most recently from 9d4dae1 to 92eb382 Compare April 11, 2019 15:11
@refack
Copy link
Contributor Author

refack commented Apr 11, 2019

Travis run now covers addons as well. minimal time approx 4(compile) + 5.5(test) minutes.

@refack refack force-pushed the optimize-travis-time branch from 544a2ff to 2879a5f Compare April 12, 2019 18:04
@refack refack added the review wanted PRs that need reviews. label Apr 12, 2019
@refack
Copy link
Contributor Author

refack commented Apr 12, 2019

@nodejs/testing @nodejs/build-files PTAL

.travis.yml Outdated Show resolved Hide resolved
@refack
Copy link
Contributor Author

refack commented Apr 12, 2019

Current master:
image

With just just parallel for JS coverage (was an in intermediate step)
image

With default:
image

So I'd call this a win.

@refack refack force-pushed the optimize-travis-time branch from cfeee14 to d3266fb Compare April 12, 2019 19:23
@richardlau
Copy link
Member

Current master:
image

With just just parallel for JS coverage (was an in intermediate step)
image

With default:
image

So I'd call this a win.

🤔
https://travis-ci.com/nodejs/node/jobs/192593470 ran 2615 tests.

https://travis-ci.com/nodejs/node/jobs/192591927 ran 2500 tests.
https://travis-ci.com/nodejs/node/jobs/192591928 ran 111 tests.
2500 + 111 = 2611 tests... Any idea what accounts for the discrepency?

@richardlau
Copy link
Member

richardlau commented Apr 12, 2019

🤔
https://travis-ci.com/nodejs/node/jobs/192593470 ran 2615 tests.

https://travis-ci.com/nodejs/node/jobs/192591927 ran 2500 tests.
https://travis-ci.com/nodejs/node/jobs/192591928 ran 111 tests.
2500 + 111 = 2611 tests... Any idea what accounts for the discrepency?

Ah it's doctool.

node/Makefile

Lines 502 to 506 in 25df3c1

test-ci: | clear-stalled build-addons build-js-native-api-tests build-node-api-tests doc-only
out/Release/cctest --gtest_output=tap:cctest.tap
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
$(TEST_CI_ARGS) $(CI_JS_SUITES) $(CI_NATIVE_SUITES) $(CI_DOC)

node/Makefile

Lines 472 to 474 in 25df3c1

CI_NATIVE_SUITES ?= addons js-native-api node-api
CI_JS_SUITES ?= default
CI_DOC := doctool

* skip compilation by using cache
* split testing into two jobs
* DRY with YAML anchors

PR-URL: nodejs#27182
Refs: nodejs#27158
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@refack refack force-pushed the optimize-travis-time branch from d3266fb to 8cf3af1 Compare April 12, 2019 20:40
@refack refack merged commit 8cf3af1 into nodejs:master Apr 12, 2019
@refack refack deleted the optimize-travis-time branch April 12, 2019 20:42
@refack refack removed their assignment Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. review wanted PRs that need reviews. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants