-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: ignore all the "Debug","Release" folders #27210
Conversation
None of those directories should be recreated. Ref: https://github.com/orgs/nodejs/teams/collaborators/discussions/72 |
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them.
@Maledong after cleaning those directories are they being created again? Also could you run |
P.S. Thank you for following up 🎩 |
Hi @refack :
Everything seems fine with it now, so nothing is created as expected.
Here's the log for you to see in details: |
Anyone to have a look at this fixture? |
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: nodejs#27210
I’m closing this as the PR author’s Github user no longer exists and this is being continued in #31565 |
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: #27210 PR-URL: #31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them.
【Before】
【After】
All the "Debug" and "Release" folders are ignored, without changes of tlog and bin files.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes