Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ignore all the "Debug","Release" folders #27210

Closed
wants to merge 2 commits into from
Closed

build: ignore all the "Debug","Release" folders #27210

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2019

Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them.

【Before】
ManyFiles
【After】
All the "Debug" and "Release" folders are ignored, without changes of tlog and bin files.


  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 13, 2019
@refack
Copy link
Contributor

refack commented Apr 13, 2019

None of those directories should be recreated.
If you are using vcbuild make sure to call is with vcbuild projgen.

Ref: https://github.com/orgs/nodejs/teams/collaborators/discussions/72

@refack refack added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Apr 13, 2019
.gitignore Outdated Show resolved Hide resolved
Since there're still many "Debug" and "Release" folders in "deps" and
"tools", to make it more strict and totally ignore the generated obj
files, ignore all the files/folders under them.
@refack
Copy link
Contributor

refack commented Apr 15, 2019

@Maledong after cleaning those directories are they being created again?

Also could you run git ls-files -i --exclude-standard, that will show you if .gitignore has rules to ignore files that are actually tracked.

@refack
Copy link
Contributor

refack commented Apr 15, 2019

P.S. Thank you for following up 🎩

@ghost
Copy link
Author

ghost commented Apr 22, 2019

Hi @refack

after cleaning those directories are they being created again?

Everything seems fine with it now, so nothing is created as expected.

Also could you run git ls-files -i --exclude-standard, that will show you if .gitignore has rules to ignore files that are actually tracked.

Here's the log for you to see in details:
Logs.txt

@ghost
Copy link
Author

ghost commented May 8, 2019

Anyone to have a look at this fixture?

DavenportEmma added a commit to DavenportEmma/node that referenced this pull request Jan 29, 2020
Since there're still many "Debug" and "Release" folders in "deps" and
"tools", to make it more strict and totally ignore the generated obj
files, ignore all the files/folders under them.

Refs: nodejs#27210
@addaleax
Copy link
Member

I’m closing this as the PR author’s Github user no longer exists and this is being continued in #31565

@addaleax addaleax closed this Jan 29, 2020
Trott pushed a commit that referenced this pull request Feb 1, 2020
Since there're still many "Debug" and "Release" folders in "deps" and
"tools", to make it more strict and totally ignore the generated obj
files, ignore all the files/folders under them.

Refs: #27210

PR-URL: #31565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
Since there're still many "Debug" and "Release" folders in "deps" and
"tools", to make it more strict and totally ignore the generated obj
files, ignore all the files/folders under them.

Refs: #27210

PR-URL: #31565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
Since there're still many "Debug" and "Release" folders in "deps" and
"tools", to make it more strict and totally ignore the generated obj
files, ignore all the files/folders under them.

Refs: #27210

PR-URL: #31565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Since there're still many "Debug" and "Release" folders in "deps" and
"tools", to make it more strict and totally ignore the generated obj
files, ignore all the files/folders under them.

Refs: #27210

PR-URL: #31565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Since there're still many "Debug" and "Release" folders in "deps" and
"tools", to make it more strict and totally ignore the generated obj
files, ignore all the files/folders under them.

Refs: #27210

PR-URL: #31565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants