Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: EC generateKeyPairSync invalid parameter encoding #27212

Closed
wants to merge 1 commit into from
Closed

Test: EC generateKeyPairSync invalid parameter encoding #27212

wants to merge 1 commit into from

Conversation

rpgeeganage
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 13, 2019
@rpgeeganage
Copy link
Contributor Author

Sorry that, I had to close the PR #27200.

@rpgeeganage rpgeeganage changed the title test: ec2 generateKeyPairSync invalid parameter encoding Test: EC generateKeyPairSync invalid parameter encoding Apr 13, 2019
@bnoordhuis
Copy link
Member

@rpgeeganage Can you rebase the old PR against master and force-push to that branch, then reopen the PR? Opening a new PR is inconvenient because the old one already had two sign-offs.

@rpgeeganage
Copy link
Contributor Author

@richardlau @bnoordhuis ,
I'm very sorry for the inconvenience.
I have already deleted that branch and I could not figure out how to reopen that PR again.
I'm so sorry.

bnoordhuis
bnoordhuis approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, no problem. The change itself still LGTM. :-)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22419/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 14, 2019
@danbev
Copy link
Contributor

danbev commented Apr 16, 2019

Landed in de463f1 🎉

@danbev danbev closed this Apr 16, 2019
danbev pushed a commit that referenced this pull request Apr 16, 2019
@rpgeeganage @danbev
test: ec2 generateKeyPairSync invalid parameter encoding
de463f1 
PR-URL: #27212
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rpgeeganage @bnoordhuis @nodejs-github-bot @danbev @richardlau @BridgeAR @ZYSzys