Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: simplify filename checks #27233

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Replace a couple of checks with a single regular expression.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Replace a couple of checks with a single regular expression.
@BridgeAR BridgeAR requested a review from addaleax April 14, 2019 23:56
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Apr 14, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 15, 2019
@nodejs-github-bot
Copy link
Collaborator

@ZYSzys
Copy link
Member

ZYSzys commented Apr 17, 2019

Landed in 5450e48 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants