Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use ArrayBufferAllocator::Create in node_worker.cc #27251

Closed
wants to merge 1 commit into from
Closed

src: use ArrayBufferAllocator::Create in node_worker.cc #27251

wants to merge 1 commit into from
+2 −3

Conversation

addaleax
Copy link
Member

Refs: #27220

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3269

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Apr 16, 2019
@addaleax addaleax mentioned this pull request Apr 16, 2019
Closed
2 tasks
bnoordhuis
bnoordhuis approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's another instance in StartNodeWithLoopAndArgs() that could also be switched over? Or is that already covered by another PR?

@addaleax
Copy link
Member Author

@bnoordhuis Yes, I think that’s covered by #27220 :)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22485/

@addaleax
Copy link
Member Author

Landed in dc8b57f

@addaleax addaleax closed this Apr 18, 2019
@addaleax addaleax deleted the worker-abc branch April 18, 2019 11:04
addaleax added a commit that referenced this pull request Apr 18, 2019
@addaleax
src: use ArrayBufferAllocator::Create in node_worker.cc
dc8b57f 
Refs: #27220

PR-URL: #27251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @bnoordhuis @jasnell @cjihrig @joyeecheung