Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix buffer-base64-decode.js #27260

Closed
wants to merge 4 commits into from

Commits on Apr 16, 2019

  1. benchmark: fix buffer-base64-decode.js

    693401d added stricter range checking
    for buffer operations and that apparently seems to have uncovered the
    fact that one of our benchmarks was overflowing a buffer. Increase the
    buffer size so the benchmark doesn't throw an error anymore.
    Trott committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    3f8ac4a View commit details
    Browse the repository at this point in the history
  2. test: fix test-benchmark-buffer

    Using `len=2` in test-benchmark-buffer was resulting in a `RangeError`
    in buffer-base64-encode.js. Change to `len=256` which works in all
    buffer benchmarks.
    Trott committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    eab7d50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b72b012 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d371b34 View commit details
    Browse the repository at this point in the history