Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: prefer v8::Global over node::Persistent #27287

Closed
wants to merge 2 commits into from

Commits on Apr 17, 2019

  1. src: prefer v8::Global over node::Persistent

    `v8::Global` is essentially a nicer variant of `node::Persistent` that,
    in addition to reset-on-destroy, also implements move semantics.
    
    This commit makes the necessary replacements, removes
    `node::Persistent` and (now-)unnecessary inclusions of the
    `node_persistent.h` header, and makes some of the functions that
    take Persistents as arguments more generic so that they work with all
    `v8::PersistentBase` flavours.
    addaleax committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    64acc76 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. Configuration menu
    Copy the full SHA
    ceb827b View commit details
    Browse the repository at this point in the history