Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase coverage in lib/internal/dns/promises.js #27330

Closed
wants to merge 1 commit into from
Closed

test: increase coverage in lib/internal/dns/promises.js #27330

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 21, 2019

Add a test for the only uncovered code in lib/internal/dns/promises.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott
test: increase coverage in lib/internal/dns/promises.js
f306d06 
Add a test for the only uncovered code in lib/internal/dns/promises.js.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3314

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 21, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22586/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2019
mhdawson
mhdawson approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Apr 23, 2019

Landed in eac8f50

@Trott Trott closed this Apr 23, 2019
Trott added a commit to Trott/io.js that referenced this pull request Apr 23, 2019
@Trott
test: increase coverage in lib/internal/dns/promises.js
eac8f50 
Add a test for the only uncovered code in lib/internal/dns/promises.js.

PR-URL: nodejs#27330
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this pull request Apr 27, 2019
@Trott @targos
test: increase coverage in lib/internal/dns/promises.js
8486917 
Add a test for the only uncovered code in lib/internal/dns/promises.js.

PR-URL: #27330
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Apr 27, 2019
Merged
@Trott Trott deleted the dns-internal-coverage branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @BridgeAR @mhdawson @ZYSzys