-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: remove Reflect.apply where appropriate #27349
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
async_hooks
Issues and PRs related to the async hooks subsystem.
fs
Issues and PRs related to the fs subsystem / file system.
process
Issues and PRs related to the process subsystem.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
labels
Apr 22, 2019
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Apr 22, 2019
Using Reflect.apply where the callback context does not need to change is unnecessary and less performant.
apapirovski
force-pushed
the
patch-replace-reflect-apply
branch
from
April 22, 2019 19:43
4340e88
to
f8bdb64
Compare
This comment has been minimized.
This comment has been minimized.
cjihrig
approved these changes
Apr 22, 2019
Fishrock123
approved these changes
Apr 22, 2019
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Apr 22, 2019
targos
approved these changes
Apr 23, 2019
devsnek
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you post the diff from the bench?
Results of micro-benchmark
|
lpinca
approved these changes
Apr 23, 2019
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 24, 2019
Landed in f4f937b. |
danbev
pushed a commit
that referenced
this pull request
Apr 30, 2019
Using Reflect.apply where the callback context does not need to change is unnecessary and less performant. PR-URL: #27349 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
Using Reflect.apply where the callback context does not need to change is unnecessary and less performant. PR-URL: #27349 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced May 7, 2019
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
async_hooks
Issues and PRs related to the async hooks subsystem.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fs
Issues and PRs related to the fs subsystem / file system.
process
Issues and PRs related to the process subsystem.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Reflect.apply where the callback context does not need to change is unnecessary and less performant.
CI: https://ci.nodejs.org/job/node-test-pull-request/22638/
Benchmarks: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/354/
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes