Skip to content

Conversation

BethGriggs
Copy link
Member

Checklist

Fix typo in Changelog ID 😅, which I believe is stopping the release post from being generated. (https://github.com/nodejs/nodejs.org/blob/master/scripts/release-post.js)

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

I'd like to fast-track this if possible, please 👍

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 23, 2019
@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 23, 2019
@BethGriggs
Copy link
Member Author

Landed in b773f77

@BethGriggs BethGriggs closed this Apr 23, 2019
BethGriggs added a commit that referenced this pull request Apr 23, 2019
PR-URL: #27368
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Apr 27, 2019
PR-URL: #27368
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Apr 27, 2019
@BethGriggs BethGriggs deleted the v12-changelog-fix branch June 11, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants