tls: include invalid method name in thrown error #27390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
mscdex
reviewed
Apr 24, 2019
sam-github
force-pushed
the
invalid-method-name-in-error
branch
from
e847200
to
cc0576f
Compare
When an invalid TLS method name error is thrown, include the invalid name in the error message.
sam-github
force-pushed
the
invalid-method-name-in-error
branch
from
cc0576f
to
5076542
Compare
sam-github
commented
Apr 24, 2019
| @@ -627,7 +627,8 @@ void SecureContext::Init(const FunctionCallbackInfo<Value>& args) { | |||
| max_version = TLS1_2_VERSION; | |||
| method = TLS_client_method(); | |||
| } else { | |||
| THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, "Unknown method"); | |||
| const std::string msg("Unknown method: "); | |||
| THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, (msg + * sslmethod).c_str()); | |||
There was a problem hiding this comment.
In case this looks like extraneous white space -- the cpp linter doesn't allow *sslmethod here, though it does in all the calls to strcmp() above.
richardlau
approved these changes
Apr 24, 2019
|
All green. @mscdex PTAL |
cjihrig
approved these changes
Apr 25, 2019
mscdex
approved these changes
Apr 25, 2019
jasnell
approved these changes
Apr 26, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 26, 2019
When an invalid TLS method name error is thrown, include the invalid name in the error message. PR-URL: nodejs#27390 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 86b4f37 |
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
When an invalid TLS method name error is thrown, include the invalid name in the error message. PR-URL: #27390 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invalid TLS method name error is thrown, include the invalid
name in the error message.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes