-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: move James back onto TSC #27411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order needs changing but other than that 👍
README.md
Outdated
@@ -179,6 +179,8 @@ For information about the governance of the Node.js project, see | |||
**Daniel Bevenius** <daniel.bevenius@gmail.com> (he/him) | |||
* [fhinkel](https://github.com/fhinkel) - | |||
**Franziska Hinkelmann** <franziska.hinkelmann@gmail.com> (she/her) | |||
* [jasnell](https://github.com/jasnell) - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should go before Joyee on line 188 rather than here?
@apapirovski thanks I guess I need to learn the alphabet better :) |
Landed in 4206e7c |
refs: nodejs/TSC#694 PR-URL: nodejs#27411 Refs: nodejs/TSC#694 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
refs: nodejs/TSC#694 PR-URL: #27411 Refs: nodejs/TSC#694 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
refs: nodejs/TSC#694
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes