doc: improve format in child_process.markdown #2744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| subshell but rather the specified file directly. This makes it slightly | ||
| leaner than `child_process.exec`. It has the same options. | ||
| leaner than [`child_process.exec`](#child_process_child_process_exec_command_options_callback). It has the same options. |
There was a problem hiding this comment.
Nit: child_process.exec() (with parentheses)
|
Some nits, but looks good to me. LGTM |
| See also [`ChildProcess#kill()`](#child_process_child_kill_signal) and | ||
| [`ChildProcess#send()`](#child_process_child_send_message_sendhandle). | ||
| See also [`ChildProcess.kill()`](#child_process_child_kill_signal) and | ||
| [`ChildProcess.send()`](#child_process_child_send_message_sendhandle). |
There was a problem hiding this comment.
The method signature changed and this should now be #child_process_child_send_message_sendhandle_callback See e.g. https://nodejs.org/api/child_process.html#child_process_child_send_message_sendhandle_callback
mscdex
added
child_process
Improved formatting in two objects descriptions and added links to referenced methods.
|
@Trott thanks for the review, updated. |
|
LGTM. Can you please rebase against master really quick. After that, should be good to go. |
|
@jasnell some modifications are no longer needed, seems easier to open a new PR. |
|
Closing in favor to #3186. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved formatting in two objects descriptions and added links to referenced methods.