Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mustCall to test-net-eaddrinuse test #27448

Closed
wants to merge 1 commit into from
Closed

test: add mustCall to test-net-eaddrinuse test #27448

wants to merge 1 commit into from

Conversation

tsy77
Copy link

@tsy77 tsy77 commented Apr 28, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@starkwang starkwang added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22756/

@starkwang starkwang added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2019
@gireeshpunathil
Copy link
Member

please leave 👍 to fast-track

@oyyd oyyd added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 28, 2019
@oyyd
Copy link
Contributor

oyyd commented Apr 28, 2019

Landed in a4fff9a, thanks!

You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute.

@oyyd oyyd closed this Apr 28, 2019
oyyd pushed a commit to oyyd/node that referenced this pull request Apr 28, 2019
@oyyd
test: add mustCall to test-net-eaddrinuse test
a4fff9a 
PR-URL: nodejs#27448
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Apr 29, 2019
@targos
test: add mustCall to test-net-eaddrinuse test
d784ecb 
PR-URL: #27448
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@molllyn1 molllyn1 mentioned this pull request Apr 15, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Apr 15, 2024
Open
@kissofire kissofire mentioned this pull request Apr 15, 2024
Open
@137717unity 137717unity mentioned this pull request Apr 15, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 15, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@starkwang starkwang starkwang approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tsy77 @nodejs-github-bot @gireeshpunathil @oyyd @cjihrig @starkwang @ZYSzys