Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fs internal util preprocessSymlinkDestination() function #27468

Closed
wants to merge 1 commit into from
Closed

test: fs internal util preprocessSymlinkDestination() function #27468

wants to merge 1 commit into from

Conversation

rpgeeganage
Copy link
Contributor

Unit tests for preprocessSymlinkDestination() function in 'internal/fs/utils'.
These tests are without any monkey-patching for the platform.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@rpgeeganage rpgeeganage changed the title test: fs internal util preprocess symlink destination test: fs internal util preprocessSymlinkDestination() function Apr 28, 2019
addaleax
addaleax approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you an even assert the exact return values of the function, instead of applying regexes here?

(Either way, this LGTM, and thank you!)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22790/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22804/

@rpgeeganage
Copy link
Contributor Author

@addaleax,
Thank you very much for the comment and approve the PR.
The problem I had is I don't have a Windows environment to actually see the output, so that's why I use the regex, based on the comment in the preprocessSymlinkDestination().
(I watched your video about The Road to Workers thread in youtube. It is really interesting.)

@addaleax
Copy link
Member

@rpgeeganage Yeah, it’s not a blocking review comment that needs to be addressed in order for this to land. :)

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2019
@rpgeeganage
Copy link
Contributor Author

@addaleax ,
Thanks a lot.

@Trott
Copy link
Member

Trott commented May 1, 2019

Landed in 64284aa

@Trott Trott closed this May 1, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 1, 2019
@rpgeeganage @Trott
fs: added tests for util file preprocessSymlinkDestination
64284aa 
PR-URL: nodejs#27468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 4, 2019
@rpgeeganage @targos
fs: added tests for util file preprocessSymlinkDestination
7be1e0a 
PR-URL: #27468
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@molllyn1 molllyn1 mentioned this pull request Apr 15, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Apr 15, 2024
Open
@kissofire kissofire mentioned this pull request Apr 15, 2024
Open
@137717unity 137717unity mentioned this pull request Apr 15, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 15, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shisama shisama shisama approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rpgeeganage @nodejs-github-bot @addaleax @Trott @cjihrig @shisama