Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix ARM vfp naming in configure script for older ARM processors #2751

Closed
wants to merge 1 commit into from
Closed

build: fix ARM vfp naming in configure script for older ARM processors #2751

wants to merge 1 commit into from

Commits on Sep 9, 2015

  1. build: fix ARM vfp in configure for older ARMs

    This commit changes the default vfp name from 'vfpv2' to 'vfp',
    affecting builds for ARM architectures older than ARMv7.
    
    Valid options for 'arm_fpu' in gcc do NOT include 'vfpv2', causing gcc
    to quit with error: unrecognized argument in option ‘-mfpu=vfpv2’ when
    using the configure script with --dest-cpu=arm.
    
    Gyp also expects only vfp, vfpv3-d16, vfpv3, neon.
    
    GCC reference for the -mfpu= option:
    https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
    Gyp makefile reference:
    https://github.com/nodejs/node/blob/v4.0.0/Makefile.build#L173
    mnkhouri committed Sep 9, 2015
    Configuration menu
    Copy the full SHA
    9bd4079 View commit details
    Browse the repository at this point in the history