Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llhttp: update to 1.1.2 #27513

Closed
wants to merge 1 commit into from
Closed

llhttp: update to 1.1.2 #27513

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented May 1, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

cc @nodejs/http

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3412

@indutny indutny requested a review from cjihrig May 1, 2019 09:22
cjihrig
cjihrig approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the commit message is failing linting. Maybe try deps: update llhttp to 1.1.2.

@indutny indutny force-pushed the feature/update-llhttp-1.1.2 branch from 869f8e8 to 11a9d53 Compare May 1, 2019 18:07
@indutny
Copy link
Member Author

indutny commented May 1, 2019

@cjihrig 🤦‍♂ my bad. Thanks for pointing out!

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 2, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22880/

@targos
Copy link
Member

targos commented May 5, 2019

Landed in 7467a5d

@targos targos closed this May 5, 2019
targos pushed a commit that referenced this pull request May 5, 2019
@indutny @targos
deps: update llhttp to 1.1.2
7467a5d 
PR-URL: #27513
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 6, 2019
@indutny @targos
deps: update llhttp to 1.1.2
55804e1 
PR-URL: #27513
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@indutny @nodejs-github-bot @targos @Trott @cjihrig @trivikr