src: remove node_options-inl.h from header files #27538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unnecessary inclusion of node_options-inl.h into env.h via inspector_agent.h, causing almost all of src/ to recompile on any change to the options parser. Its intended that *-inl.h header files are only included into the src files that call the inline methods.
nodejs-github-bot
added
c++
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22891/ (:heavy_check_mark:) |
richardlau
approved these changes
May 2, 2019
cjihrig
approved these changes
May 2, 2019
Trott
approved these changes
May 3, 2019
addaleax
approved these changes
May 3, 2019
addaleax
added
the
author ready
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 5, 2019
Fix unnecessary inclusion of node_options-inl.h into env.h via inspector_agent.h, causing almost all of src/ to recompile on any change to the options parser. Its intended that *-inl.h header files are only included into the src files that call the inline methods. PR-URL: nodejs#27538 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in c21693b |
targos
pushed a commit
that referenced
this pull request
May 5, 2019
Fix unnecessary inclusion of node_options-inl.h into env.h via inspector_agent.h, causing almost all of src/ to recompile on any change to the options parser. Its intended that *-inl.h header files are only included into the src files that call the inline methods. PR-URL: #27538 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unnecessary inclusion of node_options-inl.h into env.h via
inspector_agent.h, causing almost all of src/ to recompile on any change
to the options parser. Its intended that *-inl.h header files are only
included into the src files that call the inline methods.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes