test: better assertion for async hook tests #27601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
Trott
reviewed
May 7, 2019
Trott
approved these changes
May 7, 2019
The existing assertion was misleading to whether there were too few or too many events of a particular type. Improve the assertion message.
Flarna
approved these changes
May 8, 2019
cjihrig
approved these changes
May 8, 2019
trivikr
approved these changes
May 9, 2019
jasnell
approved these changes
May 10, 2019
Trott
added
the
author ready
|
Landed in a244b6f |
antsmartian
pushed a commit
that referenced
this pull request
May 12, 2019
The existing assertion was misleading to whether there were too few or too many events of a particular type. Improve the assertion message. PR-URL: #27601 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 13, 2019
The existing assertion was misleading to whether there were too few or too many events of a particular type. Improve the assertion message. PR-URL: #27601 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing assertion was misleading to whether there were too few or
too many events of a particular type. Improve the assertion message.
Related: #27558
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes