Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Move AnnaMag to Collaborator Emeriti list #27603

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 7, 2019

AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent
them an email asking about becoming Emeritus but did not get a response.
It's easy enough to re-onboard someone back to active status if they
become active again, so I think this is a pretty safe change to make.
I'll specifically request a review of this change from them so they get
notified and can comment/review/block/approve/etc. this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott added the meta Issues and PRs related to the general management of the project. label May 7, 2019
@Trott Trott requested a review from AnnaMag May 7, 2019 22:17
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 7, 2019
AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent
them an email asking about becoming Emeritus but did not get a response.
It's easy enough to re-onboard someone back to active status if they
become active again, so I think this is a pretty safe change to make.
I'll specifically request a review of this change from them so they get
notified and can comment/review/block/approve/etc. this.
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2019
@Trott Trott force-pushed the annamag-to-emeritus branch from 7cbfcbe to e35e4b9 Compare May 8, 2019 02:27
@Trott
Copy link
Member Author

Trott commented May 10, 2019

Landed in ec62906

@Trott Trott closed this May 10, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 10, 2019
AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent
them an email asking about becoming Emeritus but did not get a response.
It's easy enough to re-onboard someone back to active status if they
become active again, so I think this is a pretty safe change to make.
I'll specifically request a review of this change from them so they get
notified and can comment/review/block/approve/etc. this.

PR-URL: nodejs#27603
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 10, 2019
AnnaMag hasn't authored/landed/reviewed code in quite some time. I sent
them an email asking about becoming Emeritus but did not get a response.
It's easy enough to re-onboard someone back to active status if they
become active again, so I think this is a pretty safe change to make.
I'll specifically request a review of this change from them so they get
notified and can comment/review/block/approve/etc. this.

PR-URL: #27603
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
4 tasks
@AnnaMag
Copy link
Member

AnnaMag commented Mar 23, 2020

@Trott, @fhinkel Excuse the delay, I was on a maternity leave. My agenda has been really tight. LGTM, thank you.

@Trott
Copy link
Member Author

Trott commented Mar 27, 2020

I was on a maternity leave.

Congratulations!

My agenda has been really tight. LGTM, thank you.

Hope to see you back some time! Take care!

@Trott Trott deleted the annamag-to-emeritus branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants