Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: refactor stdioStringToArray function #27657

Closed
wants to merge 1 commit into from
Closed

child_process: refactor stdioStringToArray function #27657

wants to merge 1 commit into from

Conversation

zero1five
Copy link
Contributor

@zero1five zero1five commented May 12, 2019 •
edited
Loading

reduce the function in both files to one.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label May 12, 2019
@zero1five zero1five changed the title child_process: reactor stdioStringToArray function child_process: refactor stdioStringToArray function May 12, 2019
@zero1five zero1five force-pushed the refactor/child-process branch from fd4a945 to 5265c3d Compare May 12, 2019 13:53
BridgeAR
BridgeAR reviewed May 12, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken this will change the internal stdio type in case of inherit to fd. This might not change anything because the fd itself set the same but I wanted to point this out.

@BridgeAR
Copy link
Member

@nodejs/child_process PTAL at #27657 (review)

@zero1five
Copy link
Contributor Author

@BridgeAR Ah... i see. It is indeed described in the documentation that you can use inherit to create ['inherit', 'inherit', 'inherit'] or [0, 1, 2], but I Think it would be better to use a single identifier when implementing it internal. Some?

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23092/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23119/

@danbev
Copy link
Contributor

danbev commented May 15, 2019 •
edited
Loading

Re-build of failing node-test-commit-windows-fanned (✔️)

@zero1five zero1five force-pushed the refactor/child-process branch from 5265c3d to f78ff1e Compare May 15, 2019 17:07
@zero1five
child_process: refactor stdioStringToArray function
ccece4e 
reduce the function in both files to one.
@zero1five zero1five force-pushed the refactor/child-process branch from f78ff1e to ccece4e Compare May 15, 2019 17:24
@danbev
Copy link
Contributor

danbev commented May 16, 2019

Landed in 9f99d4e.

@danbev danbev closed this May 16, 2019
pull bot pushed a commit to shakir-abdo/node that referenced this pull request May 16, 2019
@zero1five @danbev
child_process: refactor stdioStringToArray function
9f99d4e 
reduce the function in both files to one.

PR-URL: nodejs#27657
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@zero1five zero1five deleted the refactor/child-process branch May 16, 2019 17:28
targos pushed a commit that referenced this pull request May 17, 2019
@zero1five @targos
child_process: refactor stdioStringToArray function
b380c0f 
reduce the function in both files to one.

PR-URL: #27657
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zero1five @BridgeAR @nodejs-github-bot @danbev @jasnell @Trott