Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: remove unused code #27676

Closed
wants to merge 1 commit into from
Closed

assert: remove unused code #27676

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Those two operators are not used.

This is an alternative to #27635. @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
assert: remove unused code
3981149 
Those two operators are not used.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3505

@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label May 13, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23096/

@Trott Trott mentioned this pull request May 13, 2019
Closed
3 tasks
@BridgeAR BridgeAR added the review wanted PRs that need reviews. label May 15, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request May 16, 2019
@BridgeAR
assert: remove unused code
35fc1b4 
Those two operators are not used.

PR-URL: nodejs#27676
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR
Copy link
Member Author

Landed in 35fc1b4 🎉

@BridgeAR BridgeAR closed this May 16, 2019
targos pushed a commit that referenced this pull request May 17, 2019
@BridgeAR @targos
assert: remove unused code
7cc21d8 
Those two operators are not used.

PR-URL: #27676
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
@BridgeAR BridgeAR deleted the remove-unused-assert-code branch January 20, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3mard 3mard 3mard approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@trivikr trivikr trivikr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BridgeAR @nodejs-github-bot @Trott @trivikr @ZYSzys @3mard