Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: v8, backport b901591 #27720

Closed
wants to merge 1 commit into from
Closed

Conversation

alexkozy
Copy link
Member

Original commit message:

inspector: added Debugger.setInstrumentationBreakpoint method

There are two possible type:

  • scriptParsed - breakpoint for any script,
  • scriptWithSourceMapParsed - breakpoint for script with
    sourceMappingURL.

When one of the breakpoints is set then for each matched script
we add breakpoint on call to top level function of that script.

Node: #24687

R=dgozman@chromium.org

Bug: chromium:887384,chromium:724793,chromium:882909
Change-Id: I9c08b2a2a5ba7006adfedd85fc92ae191517af00
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1354245
Reviewed-by: Jakob Gruber jgruber@chromium.org
Reviewed-by: Yang Guo yangguo@chromium.org
Reviewed-by: Dmitry Gozman dgozman@chromium.org
Reviewed-by: Alexei Filippov alph@chromium.org
Commit-Queue: Aleksey Kozyatinskiy kozyatinskiy@chromium.org
Cr-Commit-Position: refs/heads/master@{#61353}

Issue: #24687

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 15, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member

@nodejs/inspector PTAL

Original commit message:

inspector: added Debugger.setInstrumentationBreakpoint method

There are two possible type:
- scriptParsed - breakpoint for any script,
- scriptWithSourceMapParsed - breakpoint for script with
  sourceMappingURL.

When one of the breakpoints is set then for each matched script
we add breakpoint on call to top level function of that script.

Node: nodejs#24687
@alexkozy alexkozy changed the base branch from master to canary-base August 2, 2019 18:10
@alexkozy alexkozy changed the base branch from canary-base to master August 2, 2019 18:10
@alexkozy alexkozy changed the base branch from master to v12.x August 2, 2019 18:11
@alexkozy
Copy link
Member Author

alexkozy commented Aug 2, 2019

This commit adds a method that is required to provide better-debugging experience for scripts with source maps by different IDE, e.g. VSCode. If we backport it to Node 12, we can get this support in VSCode faster.

At the same time, this commit only adds the minor feature to protocol and does not change anything around, so the risk that it breaks something is minimal.

@alexkozy
Copy link
Member Author

alexkozy commented Aug 7, 2019

V8 backport which includes this commit is coming: #28955

@alexkozy alexkozy closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants