Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: ignore SIGXFSZ, don't terminate (ulimit -f) #27798

Merged
merged 1 commit into from
May 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ inline void PlatformInit() {
for (unsigned nr = 1; nr < kMaxSignal; nr += 1) {
if (nr == SIGKILL || nr == SIGSTOP)
continue;
act.sa_handler = (nr == SIGPIPE) ? SIG_IGN : SIG_DFL;
act.sa_handler = (nr == SIGPIPE || nr == SIGXFSZ) ? SIG_IGN : SIG_DFL;
CHECK_EQ(0, sigaction(nr, &act, nullptr));
}
#endif // !NODE_SHARED_MODE
Expand Down
32 changes: 32 additions & 0 deletions test/parallel/test-fs-write-sigxfsz.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// Check that exceeding RLIMIT_FSIZE fails with EFBIG
// rather than terminating the process with SIGXFSZ.
'use strict';
const common = require('../common');
const tmpdir = require('../common/tmpdir');

const assert = require('assert');
const child_process = require('child_process');
const fs = require('fs');
const path = require('path');

if (common.isWindows)
common.skip('no RLIMIT_FSIZE on Windows');

if (process.config.variables.node_shared)
common.skip('SIGXFSZ signal handler not installed in shared library mode');

if (process.argv[2] === 'child') {
const filename = path.join(tmpdir.path, 'efbig.txt');
tmpdir.refresh();
fs.writeFileSync(filename, '.'.repeat(1 << 16)); // Exceeds RLIMIT_FSIZE.
} else {
const cmd = `ulimit -f 1 && '${process.execPath}' '${__filename}' child`;
const result = child_process.spawnSync('/bin/sh', ['-c', cmd]);
const haystack = result.stderr.toString();
const needle = 'Error: EFBIG: file too large, write';
const ok = haystack.includes(needle);
if (!ok) console.error(haystack);
assert(ok);
assert.strictEqual(result.status, 1);
assert.strictEqual(result.stdout.toString(), '');
}