Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] Using DEBUG_HTTP2SESSION to fix build failure with --debug-http2 #27826

Closed
wants to merge 1 commit into from
Closed

[v8.x] Using DEBUG_HTTP2SESSION to fix build failure with --debug-http2 #27826

wants to merge 1 commit into from

Conversation

kasicka
Copy link

@kasicka kasicka commented May 22, 2019

Fixes #27824

Checklist
  • [ x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

addaleax
addaleax approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@addaleax addaleax changed the title Using DEBUG_HTTP2SESSION to fix build failure with --debug-http2 [v8.x] Using DEBUG_HTTP2SESSION to fix build failure with --debug-http2 May 22, 2019
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. v8.x labels May 22, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23279/

@sam-github sam-github closed this Jun 5, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Jan 2, 2020

@sam-github was this actually closed by accident?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kasicka @nodejs-github-bot @BridgeAR @addaleax @cjihrig @BethGriggs @sam-github