Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: fix tracking received data for maxSessionMemory #27914

Closed

Commits on May 26, 2019

  1. http2: fix tracking received data for maxSessionMemory

    Track received data correctly. Specifically, for the buffer that
    is used for receiving data, we previously would try to increment
    the current memory usage by its length, and later decrement it
    by that, but in the meantime the buffer had been turned over to V8
    and its length reset to zero. This gave the impression that more and
    more memory was consumed by the HTTP/2 session when it was in fact not.
    
    Fixes: nodejs#27416
    Refs: nodejs#26207
    addaleax committed May 26, 2019
    Configuration menu
    Copy the full SHA
    4b5176f View commit details
    Browse the repository at this point in the history