-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: adds link to nightly code coverage report #27922
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
reviewed
May 27, 2019
Adds a link to the nightly test code coverage report page to the writing-tests.md documentation.
srcmake
force-pushed
the
doc/code-coverage-link
branch
from
May 27, 2019 01:57
f558e68
to
fc42d1e
Compare
Trott
approved these changes
May 27, 2019
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 27, 2019
richardlau
approved these changes
May 27, 2019
lpinca
approved these changes
May 27, 2019
mhdawson
approved these changes
May 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BridgeAR
approved these changes
May 29, 2019
trivikr
approved these changes
May 29, 2019
Landed in 18be288. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 30, 2019
Adds a link to the nightly test code coverage report page to the writing-tests.md documentation. PR-URL: nodejs#27922 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 31, 2019
Adds a link to the nightly test code coverage report page to the writing-tests.md documentation. PR-URL: #27922 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The writing-tests.md file leads to documentation on generating a test code coverage report, but doesn't actually link to the page with the nightly code coverage report. (Actually, the Nightly Code Coverage Report doesn't seem to be linked anywhere in the project.)
This PR adds a link to the Nightly Test Code Coverage Report in the writing-tests.md file (specifically, in the Test Coverage section).
Checklist