Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adds link to nightly code coverage report #27922

Closed
wants to merge 1 commit into from

Conversation

srcmake
Copy link
Contributor

@srcmake srcmake commented May 27, 2019

Description

The writing-tests.md file leads to documentation on generating a test code coverage report, but doesn't actually link to the page with the nightly code coverage report. (Actually, the Nightly Code Coverage Report doesn't seem to be linked anywhere in the project.)

This PR adds a link to the Nightly Test Code Coverage Report in the writing-tests.md file (specifically, in the Test Coverage section).

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 27, 2019
doc/guides/writing-tests.md Outdated Show resolved Hide resolved
Adds a link to the nightly test code coverage report page
to the writing-tests.md documentation.
@srcmake srcmake force-pushed the doc/code-coverage-link branch from f558e68 to fc42d1e Compare May 27, 2019 01:57
@Trott
Copy link
Member

Trott commented May 27, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented May 30, 2019

Landed in 18be288.

@Trott Trott closed this May 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
Adds a link to the nightly test code coverage report page
to the writing-tests.md documentation.

PR-URL: nodejs#27922
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 31, 2019
Adds a link to the nightly test code coverage report page
to the writing-tests.md documentation.

PR-URL: #27922
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants