meta: create github support file #27926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
added
the
meta
Trott
requested changes
May 27, 2019
|
(I'd also recommend replacing the information in README with a link to this file so we don't have to update information in two places.) |
|
This is what I was going to propose, if it helps: master...Trott:support-file |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 27, 2019
The GitHub interface will display links to SUPPORT.md in hopefully-helpful places so let's take advantage of that and move the support information to there and out of our README (but include a link to the new SUPPORT.md). Fixes: nodejs#27926
Refs: help.github.com/en/articles/adding-support-resources-to-your-project
Trott
approved these changes
May 27, 2019
|
Looks like maybe the lite CI's didn't start automatically. Here's a manually-started Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3629/ |
Trott
added
the
author ready
cjihrig
approved these changes
May 27, 2019
keywordnew
reviewed
May 27, 2019
There was a problem hiding this comment.
Looks great folks!
My non-blocking comment would be to add what the suggested resources are good for, so unfamiliar people can make better choices without as much guesswork.
For example:
* [Node.js Website](https://nodejs.org/en/)
Good for general information, links to latest changelogs, API docs.
bnb
approved these changes
May 27, 2019
|
Thank you @devsnek for PRng this in! 💖 |
Co-Authored-By: Tierney Cyren <accounts@bnb.im>
Trott
reviewed
May 28, 2019
Co-Authored-By: Rich Trott <rtrott@gmail.com>
WaleedAshraf
approved these changes
May 28, 2019
BridgeAR
approved these changes
May 29, 2019
trivikr
approved these changes
May 29, 2019
|
Landed in f469522 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 30, 2019
PR-URL: nodejs#27926 Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 31, 2019
PR-URL: #27926 Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nodejs/tsc @nodejs/community-committee
Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project
Checklist