process: expose uv_rusage on process.resourceUsage() #28018

vmarchaud · 2019-06-02T11:43:05Z

As discussed in nodejs/diagnostics#161,
the core should expose important metrics about the runtime, this PR's
goal is to let user get the number of io request made, and lower level
metrics like the page faults and context switches.

~~The make -j4 test are not passing locally because of a failing test test/parallel/test-worker-prof.js but i believe it's not related to my changes.~~
Concerning the tests, i didn't really tested the output of the function mainly because it might make the test flaky depending on the platform and runtime behavior.

This is my first PR on the core, so i might have forgotten some requirements.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

doc/api/process.md

src/node_process_methods.cc

test/parallel/test-resources-usage.js

Trott · 2019-06-02T11:57:23Z

This is my first PR on the core, so i might have forgotten some requirements.

Looks like you didn't forget anything. Thanks for the pull request and welcome!

nodejs-github-bot · 2019-06-02T11:58:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23555/

test/parallel/test-resources-usage.js

Trott · 2019-06-02T18:05:38Z

Any reason this would make test-worker-prof less reliable? It's failing a lot in CI here, but I'm not sure if it's because of the changes here or something else?

doc/api/process.md

cjihrig · 2019-06-02T21:51:39Z

doc/api/process.md

+-->
+
+* Returns: {Object}
+    * `minflt` {integer}


I'm not sure if it matters at the JS level, but these are all unsigned integers.

doc/api/process.md

test/parallel/test-resources-usage.js

bnoordhuis

LGTM. My comments are not blockers.

doc/api/process.md

test/parallel/test-resource-usage.js

vmarchaud · 2019-06-05T09:31:23Z

I've switched to full names, added the mapping between node names and libuv ones. Also exposed all the fields even if not supported as @bnoordhuis said.

BridgeAR · 2019-06-05T10:26:35Z

What benefit do we have by exposing entries that are not supported on any platform?

addaleax · 2019-06-05T10:30:07Z

@BridgeAR Future-proofing and standards conformance would be the two big pro arguments, I imagine?

doc/api/process.md

vmarchaud · 2019-06-06T12:12:37Z

I believe the PR is good to be merged expect if someone has a blocker on the exposed fields ?

vmarchaud · 2019-06-18T09:05:07Z

I've rebased on master hoping that the test on worker-prof will pass now

nodejs-github-bot · 2019-06-18T20:32:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23968/

nodejs-github-bot · 2019-06-18T21:07:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23970/

vmarchaud · 2019-06-24T21:02:08Z

I've checked the test failures and it doesn't seems to be related to this PR, what are the next steps in this case ?

nodejs-github-bot · 2019-06-24T23:56:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24081/

nodejs-github-bot · 2019-06-25T01:26:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24082/

nodejs-github-bot · 2019-06-25T01:36:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24084/

As discussed in nodejs/diagnostics#161, the core should expose important metrics about the runtime, this PR's goal is to let user get the number of io request made, and lower level mertrics like the page faults and context switches.

vmarchaud · 2019-07-01T12:57:59Z

@Trott I'm not sure what are the next steps, do you think the PR can be merged ?

addaleax · 2019-07-01T14:14:46Z

@vmarchaud Thanks for the ping!

Landed in 6271ef0 🎉

As discussed in nodejs/diagnostics#161, the core should expose important metrics about the runtime, this PR's goal is to let user get the number of io request made, and lower level mertrics like the page faults and context switches. PR-URL: #28018 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable changes: * build: * Experimental support for building Node.js on MIPS architecture is back. #27992 * child_process: * The promisified versions of `child_process.exec` and `child_process.execFile` now both return a `Promise` which has the child instance attached to their `child` property. #28325 * deps: * Updated libuv to 1.30.0. #28449 * Support for the Haiku platform has been added. * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to 1024. * `uv_fs_copyfile()` now works properly when the source and destination files are the same. * process: * A new method, `process.resourceUsage()` was added. It returns resource usage for the current process, such as CPU time. #28018 * src: * Fixed an issue related to stdio that could lead to a crash of the process in some circumstances. #28490 * stream: * Added a `writableFinished` property to writable streams. It indicates that all the data has been flushed to the underlying system. #28007 * worker: * Fixed an issue that prevented worker threads to listen for data on stdin. #28153 PR-URL: #28508

Notable changes: * build: * Experimental support for building Node.js on MIPS architecture is back. #27992 * child_process: * The promisified versions of `child_process.exec` and `child_process.execFile` now both return a `Promise` which has the child instance attached to their `child` property. #28325 * deps: * Updated libuv to 1.30.0. #28449 * Support for the Haiku platform has been added. * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to 1024. * `uv_fs_copyfile()` now works properly when the source and destination files are the same. * process: * A new method, `process.resourceUsage()` was added. It returns resource usage for the current process, such as CPU time. #28018 * src: * Fixed an issue related to stdio that could lead to a crash of the process in some circumstances. #28490 * stream: * Added a `writableFinished` property to writable streams. It indicates that all the data has been flushed to the underlying system. #28007 * worker: * Fixed an issue that prevented worker threads to listen for data on stdin. #28153 * meta: * Added Jiawen Geng (https://github.com/gengjiawen) to collaborators. #28322 PR-URL: #28508

Notable changes: * build: * Experimental support for building Node.js on MIPS architecture is back. #27992 * child_process: * The promisified versions of `child_process.exec` and `child_process.execFile` now both return a `Promise` which has the child instance attached to their `child` property. #28325 * deps: * Updated libuv to 1.30.1. #28449, #28511 * Support for the Haiku platform has been added. * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to 1024. * `uv_fs_copyfile()` now works properly when the source and destination files are the same. * process: * A new method, `process.resourceUsage()` was added. It returns resource usage for the current process, such as CPU time. #28018 * src: * Fixed an issue related to stdio that could lead to a crash of the process in some circumstances. #28490 * stream: * Added a `writableFinished` property to writable streams. It indicates that all the data has been flushed to the underlying system. #28007 * worker: * Fixed an issue that prevented worker threads to listen for data on stdin. #28153 * meta: * Added Jiawen Geng (https://github.com/gengjiawen) to collaborators. #28322 PR-URL: #28508

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. process Issues and PRs related to the process subsystem. labels Jun 2, 2019

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 2, 2019

addaleax reviewed Jun 2, 2019

View reviewed changes

doc/api/process.md Outdated Show resolved Hide resolved

src/node_process_methods.cc Outdated Show resolved Hide resolved

Trott reviewed Jun 2, 2019

View reviewed changes

test/parallel/test-resources-usage.js Outdated Show resolved Hide resolved

vmarchaud force-pushed the resources-usage branch 3 times, most recently from dfdcae7 to 2eff3d1 Compare June 2, 2019 12:41

addaleax removed the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jun 2, 2019

Trott reviewed Jun 2, 2019

View reviewed changes

test/parallel/test-resources-usage.js Outdated Show resolved Hide resolved

cjihrig reviewed Jun 2, 2019

View reviewed changes

vmarchaud force-pushed the resources-usage branch 4 times, most recently from 315c0e1 to 3f0d72b Compare June 3, 2019 11:31

bnoordhuis approved these changes Jun 3, 2019

View reviewed changes

doc/api/process.md Show resolved Hide resolved

doc/api/process.md Outdated Show resolved Hide resolved

cjihrig approved these changes Jun 3, 2019

View reviewed changes

doc/api/process.md Outdated Show resolved Hide resolved

doc/api/process.md Outdated Show resolved Hide resolved

test/parallel/test-resource-usage.js Outdated Show resolved Hide resolved

vmarchaud changed the title ~~process: expose uv_rusage on process.resourcesUsage()~~ process: expose uv_rusage on process.resourceUsage() Jun 5, 2019

vmarchaud force-pushed the resources-usage branch from 3f0d72b to 68947b7 Compare June 5, 2019 09:30

addaleax approved these changes Jun 5, 2019

View reviewed changes

doc/api/process.md Show resolved Hide resolved

doc/api/process.md Outdated Show resolved Hide resolved

vmarchaud force-pushed the resources-usage branch 2 times, most recently from d6374b6 to 7bed043 Compare June 5, 2019 12:51

vmarchaud force-pushed the resources-usage branch 2 times, most recently from b582b90 to d9579de Compare June 18, 2019 09:04

vmarchaud force-pushed the resources-usage branch from d9579de to 99f777f Compare June 30, 2019 14:04

process: expose uv_rusage on process.resourcesUsage()

d770f66

As discussed in nodejs/diagnostics#161, the core should expose important metrics about the runtime, this PR's goal is to let user get the number of io request made, and lower level mertrics like the page faults and context switches.

vmarchaud force-pushed the resources-usage branch from 99f777f to d770f66 Compare June 30, 2019 22:17

addaleax closed this Jul 1, 2019

SimenB mentioned this pull request Jul 1, 2019

Resource usage from Node siimon/prom-client#279

Open

vmarchaud deleted the resources-usage branch July 1, 2019 20:35

targos mentioned this pull request Jul 2, 2019

Release v12.6.0 proposal #28508

Merged

This was referenced Jul 3, 2019

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#288

Closed

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#289

Closed

2019-07-03 Version 12.6.0 (Current) @targos beevelop/docker-nodejs#290

Closed

BethGriggs added the dont-land-on-v10.x label Sep 3, 2019

mscdex mentioned this pull request Mar 22, 2022

Supported platform of some fields in process.resourceUsage #42436

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

process: expose uv_rusage on process.resourceUsage() #28018

process: expose uv_rusage on process.resourceUsage() #28018

vmarchaud commented Jun 2, 2019 •

edited

Loading

Trott commented Jun 2, 2019

nodejs-github-bot commented Jun 2, 2019

Trott commented Jun 2, 2019

cjihrig Jun 2, 2019

bnoordhuis left a comment

vmarchaud commented Jun 5, 2019

BridgeAR commented Jun 5, 2019

addaleax commented Jun 5, 2019

vmarchaud commented Jun 6, 2019

vmarchaud commented Jun 18, 2019

nodejs-github-bot commented Jun 18, 2019

nodejs-github-bot commented Jun 18, 2019

vmarchaud commented Jun 24, 2019

nodejs-github-bot commented Jun 24, 2019

nodejs-github-bot commented Jun 25, 2019

nodejs-github-bot commented Jun 25, 2019

vmarchaud commented Jul 1, 2019

addaleax commented Jul 1, 2019

process: expose uv_rusage on process.resourceUsage() #28018

process: expose uv_rusage on process.resourceUsage() #28018

Conversation

vmarchaud commented Jun 2, 2019 • edited Loading

Checklist

Trott commented Jun 2, 2019

nodejs-github-bot commented Jun 2, 2019

Trott commented Jun 2, 2019

cjihrig Jun 2, 2019

Choose a reason for hiding this comment

bnoordhuis left a comment

Choose a reason for hiding this comment

vmarchaud commented Jun 5, 2019

BridgeAR commented Jun 5, 2019

addaleax commented Jun 5, 2019

vmarchaud commented Jun 6, 2019

vmarchaud commented Jun 18, 2019

nodejs-github-bot commented Jun 18, 2019

nodejs-github-bot commented Jun 18, 2019

vmarchaud commented Jun 24, 2019

nodejs-github-bot commented Jun 24, 2019

nodejs-github-bot commented Jun 25, 2019

nodejs-github-bot commented Jun 25, 2019

vmarchaud commented Jul 1, 2019

addaleax commented Jul 1, 2019

vmarchaud commented Jun 2, 2019 •

edited

Loading