Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make sure vtable is generated in addon test with LTO #28057

Closed
wants to merge 1 commit into from
Closed

test: make sure vtable is generated in addon test with LTO #28057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/addons/uv-handle-leak/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,16 @@ void CloseCallback(uv_handle_t* handle) {}

class ExampleOwnerClass {
public:
virtual ~ExampleOwnerClass() {}
virtual ~ExampleOwnerClass();
};

// Do not inline this into the class, because that may remove the virtual
// table when LTO is used, and with it the symbol for which we grep the process
// output in test/abort/test-addon-uv-handle-leak.
// When the destructor is not inlined, the compiler will have to assume that it,
// and the vtable, is part of what this compilation unit exports, and keep them.
ExampleOwnerClass::~ExampleOwnerClass() {}

ExampleOwnerClass example_instance;

void LeakHandle(const FunctionCallbackInfo<Value>& args) {
Expand Down