Cleanup old ssl code #28085
Closed
Cleanup old ssl code #28085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this true when using system copies of OpenSSL? I don't remember if there was ever a decision about this. |
|
It was discussed, I can dig the conversation up if I have to (perhaps in the TSC PR on the openssl strategy? or the tls1.3 PR? or the tls1.3 "help wanted" issue?), but if you try you will find that node |
|
And by "does not compile" I mean "did not compile even before this PR" (just to be clear). |
bnoordhuis
approved these changes
Jun 6, 2019
|
@mscdex FYI, errors in node master for build of node_crypto.cc against openssl 1.1.0: https://gist.github.com/sam-github/75f33f84b39e822f6e06e87c16e83ab3 |
|
@mscdex Did I address your concerns? Can you review, please? |
Versions of OpenSSL lower than 1.1.1 are no longer supported, so remove ifdefs for previous versions.
Workaround added in d9b9229 is no longer needed, since OpenSSL versions lower than 1.1.1 are unsupported.
sam-github
force-pushed
the
cleanup-old-ssl-code
branch
from
ee9a65e
to
cd8cf1a
Compare
apapirovski
approved these changes
Jun 8, 2019
jasnell
approved these changes
Jun 10, 2019
cjihrig
approved these changes
Jun 10, 2019
addaleax
approved these changes
Jun 10, 2019
addaleax
added
crypto
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2019
Versions of OpenSSL lower than 1.1.1 are no longer supported, so remove ifdefs for previous versions. PR-URL: #28085 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2019
Workaround added in d9b9229 is no longer needed, since OpenSSL versions lower than 1.1.1 are unsupported. PR-URL: #28085 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
@addaleax Confirmed: should not land on 10.x and 8.x, they support external openssl |
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
Versions of OpenSSL lower than 1.1.1 are no longer supported, so remove ifdefs for previous versions. PR-URL: #28085 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
Workaround added in d9b9229 is no longer needed, since OpenSSL versions lower than 1.1.1 are unsupported. PR-URL: #28085 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes