Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify weak keys text #28090

Merged
merged 1 commit into from
Jun 9, 2019
Merged

doc: clarify weak keys text #28090

merged 1 commit into from
Jun 9, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 6, 2019

Describe small key sizes as "too weak for safe use" rather than
"considered to be too weak for safe use".

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
Copy link
Member Author

Trott commented Jun 6, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3651/

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. crypto Issues and PRs related to the crypto subsystem. labels Jun 6, 2019
@Trott
doc: clarify weak keys text
50a4e00 
Describe small key sizes as "too weak for safe use" rather than
"considered to be too weak for safe use".

PR-URL: nodejs#28090
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott Trott force-pushed the considered-to-be branch from 29ca7a1 to 50a4e00 Compare June 9, 2019 01:16
@Trott
Copy link
Member Author

Trott commented Jun 9, 2019

Landed in 50a4e00

@Trott Trott merged commit 50a4e00 into nodejs:master Jun 9, 2019
@Trott Trott deleted the considered-to-be branch June 9, 2019 01:19
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@Trott @BridgeAR
doc: clarify weak keys text
f95a52c 
Describe small key sizes as "too weak for safe use" rather than
"considered to be too weak for safe use".

PR-URL: #28090
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @bnoordhuis @cjihrig @BridgeAR @trivikr